New pattern-kinesis data stream & lambda consumer#1609
Merged
boyney123 merged 6 commits intoaws-samples:mainfrom Sep 18, 2023
Merged
New pattern-kinesis data stream & lambda consumer#1609boyney123 merged 6 commits intoaws-samples:mainfrom
boyney123 merged 6 commits intoaws-samples:mainfrom
Conversation
|
@awsrahulrsr looks like you are missing the example-pattern.json file in your pattern. You can find the example-pattern template here. The file is used on ServerlessLand and is required. Once the file is added we can review the pattern. |
Contributor
|
Hey @awsrahulrsr , Missing the example-pattern json file in your pull request, once you add that we can review your pattern. Thanks |
Contributor
Author
|
Hi @boyney123, Added example-pattern.json file. Please let me know if any further changes are needed. |
github-actions
Bot
added
valid-example-pattern-file
and removed
requested-changes
missing-example-pattern-file
labels
boyney123
reviewed
Sep 18, 2023
Contributor
|
Thank you @awsrahulrsr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
My email - rahulrsr@amazon.com