New serverless pattern: s3 trigger fargate task #2379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellisms
requested changes
Aug 5, 2024
Contributor
ellisms
left a comment
ellisms
left a comment
There was a problem hiding this comment.
@jeromevdl Thanks for the submission. Requesting a few minor changes.
Contributor
|
@jeromevdl Were you able to review my comments and make changes? |
Contributor
Author
|
I completely missed the notification, will have a look, thanks for the reminder |
Co-authored-by: ellisms <114107920+ellisms@users.noreply.github.com>
Contributor
Author
|
there's still requested changes, but I see nothing to change in the discussion... |
ellisms
approved these changes
Nov 1, 2024
Contributor
|
Sorry, I didn't approve them. They are now approved and this is in the queue to publish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #2378
Description of changes:
Adding a new pattern: S3 -> EventBridge -> Fargate, using CDK / Typescript
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.