New serverless pattern - Private Api Gateway Custom Domain Name #2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usama-khan98
changed the title
marcojahn
requested changes
Dec 17, 2024
Contributor
marcojahn
left a comment
marcojahn
left a comment
There was a problem hiding this comment.
Hello @usama-khan98, thank your for you contribution. I made a few small requests for changes. Pls review and update. TY
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
Co-authored-by: Marco <marco.jahn@gmail.com>
marcojahn
approved these changes
Dec 18, 2024
Contributor
|
Thank you @usama-khan98 for your contribution. Your PR fill be merged to serverlessland patterns by a DA soon. |
usama-khan98
deleted the
usama-khan98-feature-private-apigw-custom-domain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #2522
Description of changes:
New SAM templates to create Private REST API Gateway with Private Custom Domain Name.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.