sfn-glue-sam: Replace deprecated Python shell 3.6 with 3.9#3130
Merged
Conversation
kakakakakku
commented
Jun 8, 2026
kakakakakku
commented
Jun 8, 2026
ellisms
requested changes
Jun 22, 2026
ellisms
left a comment
Contributor
There was a problem hiding this comment.
Thanks @kakakakakku. I left a few comments to be addressed.
Contributor
|
Thanks for the updates @kakakakakku . Adding this to the publishing queue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Hi😀 Thanks for the useful patterns!
This pattern was last updated about 5 years ago and currently doesn't work because Python shell 3.6 reached end of support on March 1, 2026. I made the following updates to bring it back to a working state.
Check
sam deploycompleted successfully and works good.$ aws s3 mb s3://kakakakakku-sfn-glue-sam-artifacts make_bucket: kakakakakku-sfn-glue-sam-artifacts $ aws s3 mb s3://kakakakakku-sfn-glue-sam-data make_bucket: kakakakakku-sfn-glue-sam-data $ aws s3 cp code/glue s3://kakakakakku-sfn-glue-sam-artifacts/glue --recursive $ sam build --template code/cloudformation/stack.yaml $ sam deploy --guided CloudFormation outputs from deployed stack ----------------------------------------------------------------------------------------------------------------------------- Outputs ----------------------------------------------------------------------------------------------------------------------------- Key GlueJobName Description - Value Feature Engineering Key ETLStepFunctionsARN Description - Value arn:aws:states:ap-northeast-1:000000000000:stateMachine:ETLStepFunctions-9pMndnlymAiz ----------------------------------------------------------------------------------------------------------------------------- Successfully created/updated stack - sfn-glue-sam in ap-northeast-1Thank you😀
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.