Added iam:getRole perms to CF1 remediation #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmekari
requested review from
a team,
CrypticCabub,
G-Lenz,
dougtoppin,
gsingh04,
hearde and
schana
hearde
approved these changes
Mar 10, 2023
| iamPerms.addActions('iam:GetRole'); | ||
| iamPerms.effect = Effect.ALLOW; | ||
| iamPerms.addResources( | ||
| `arn:${this.partition}:iam::${this.account}:role/${remediationRoleNameBase}${remediationName}` |
Contributor
There was a problem hiding this comment.
no change needed: this file is written in the style of crafting policies explicitly. CDK offers another way to manage permissions called grants: https://docs.aws.amazon.com/cdk/v2/guide/permissions.html
I think for new code we should try to use that method since you don't have to craft the whole policy and build the arn pattern, you just say role.grant(role, 'GetRole');, I think.
CrypticCabub
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added IAM Perms to CloudFormation.1 remediation to fix issue with nested stacks.
Verified failure before fix, tested and deployed fix, and verified that it succeeded on the same stack.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.