feat: support BYO filesystem (S3 Files / EFS) in schema and CLI#1220
Open
johanneslanger wants to merge 1 commit into
Open
feat: support BYO filesystem (S3 Files / EFS) in schema and CLI#1220johanneslanger wants to merge 1 commit into
johanneslanger wants to merge 1 commit into
Conversation
… and CLI Extends filesystemConfigurations to accept s3FilesAccessPoint and efsAccessPoint entries alongside the existing sessionStorage type. Changes: - Extended FilesystemConfigurationSchema with S3FilesAccessPointSchema and EfsAccessPointSchema (Zod validators with ARN pattern matching) - Added CLI flags: --s3-files-access-point-arn, --s3-files-mount-path, --efs-access-point-arn, --efs-mount-path - Added validation requiring ARN + mount path pairs - Regenerated agentcore.schema.v1.json from Zod - Added 17 unit tests covering schema validation and CLI option validation Closes aws#1205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for BYO (bring-your-own) filesystem configurations in
agentcore.jsonand the CLI, enabling S3 Files access points and EFS access points alongside the existing session storage.Closes #1205
Changes
Schema (
src/schema/schemas/agent-env.ts)S3FilesAccessPointSchemawith ARN pattern validation forarn:*:s3files:*access pointsEfsAccessPointSchemawith ARN pattern validation forarn:*:elasticfilesystem:*access pointsFilesystemConfigurationSchemato acceptsessionStorage,s3FilesAccessPoint, orefsAccessPoint(at least one required per entry)schemas/agentcore.schema.v1.jsonCLI (
src/cli/primitives/AgentPrimitive.tsx)--s3-files-access-point-arn,--s3-files-mount-path,--efs-access-point-arn,--efs-mount-pathbuildFilesystemConfigurations()helper that assembles the array from flat CLI optionsValidation (
src/cli/commands/add/validate.ts)isValidArn()utility/mnt/<name>pattern as session storageWhat's NOT in this PR
s3files:ClientMount, etc.) — these belong in@aws/agentcore-cdkand will be a follow-up PR against that packageagentcore createTUI wizard — BYO filesystems are a non-interactive advanced feature; the TUI wizard continues to offer only session storageTesting
Example usage
Resulting
agentcore.json:{ "filesystemConfigurations": [ { "s3FilesAccessPoint": { "accessPointArn": "arn:aws:s3files:eu-central-1:123456789012:access-point/skills-ap", "mountPath": "/mnt/skills" } } ] }