Skip to content

fix: skip schema-check and pr-title validation on release PRs#1272

Merged
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:fix/skip-ci-on-release-prs
May 15, 2026
Merged

fix: skip schema-check and pr-title validation on release PRs#1272
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:fix/skip-ci-on-release-prs

Conversation

@Hweinstock
Copy link
Copy Markdown
Contributor

@Hweinstock Hweinstock commented May 15, 2026

Description

Skip the schema-check job and PR title validation on auto-created release PRs by using a release label.

  • The release workflow now adds --label release to gh pr create
  • pr-title.yml adds release to ignoreLabels so semantic title validation is skipped
  • lint.yml adds an if condition to schema-check to skip when the release label is present

Ex. #1271 has these checks failing, but its just noise since we don't care about these checks on release branches.

Related Issue

N/A — fixing CI failures on auto-created release PRs.

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

Add 'release' label to auto-created release PRs and use it to skip
the schema-check job and PR title validation that incorrectly fail
on release PRs.
@github-actions github-actions Bot added the size/xs PR size: XS label May 15, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.13.1.tgz

How to install

npm install https://github.com/aws/agentcore-cli/releases/download/pr-1272-tarball/aws-agentcore-0.13.1.tgz

Copy link
Copy Markdown

@agentcore-cli-automation agentcore-cli-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The label-based approach is reasonable, but there's one blocker: the release label does not currently exist in this repository.

Running gh label list shows labels like pending release, bug, dependencies, ci, etc., but no release label. When the release workflow runs, gh pr create --label release will fail with something like could not add label: 'release' not found, which would break the entire release workflow this PR is trying to fix.

A few options to address this:

  1. Create the release label in the repo before merging (via the GitHub UI or gh label create release). Simple and keeps the workflow change minimal.
  2. Create the label idempotently in the workflow before gh pr create, e.g.:
    - name: Ensure release label exists
      env:
        GH_TOKEN: ${{ github.token }}
      run: gh label create release --color ededed --description "Auto-created release PR" --force
    This makes the workflow self-contained.
  3. Reuse the existing pending release label instead of introducing a new one. Update both the lint.yml contains(...) check and pr-title.yml's ignoreLabels to use pending release, and pass --label "pending release" in release.yml. (Note: that label seems to be used elsewhere with different semantics, so option 1 or 2 is probably cleaner.)

Option 1 or 2 is preferred.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 15, 2026
@Hweinstock
Copy link
Copy Markdown
Contributor Author

Hweinstock commented May 15, 2026

I think it might create on first api call, but created release in advance to be safe.

https://github.com/aws/agentcore-cli/issues/labels?q=state%3Aopen%20label%3Arelease

@Hweinstock
Copy link
Copy Markdown
Contributor Author

e2e test failure from https://github.com/aws/aws-sdk-js-v3/issues, unrelated to PR.

@Hweinstock Hweinstock marked this pull request as ready for review May 15, 2026 21:05
@Hweinstock Hweinstock requested a review from a team May 15, 2026 21:05
Copy link
Copy Markdown
Contributor

@jesseturner21 jesseturner21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is lovely

@Hweinstock Hweinstock merged commit d92fac2 into aws:main May 15, 2026
29 of 31 checks passed
@Hweinstock Hweinstock deleted the fix/skip-ci-on-release-prs branch May 15, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants