Skip to content

fix: build CLI before running integration tests#1286

Merged
Hweinstock merged 2 commits into
aws:mainfrom
Hweinstock:fix/integ-tests-build-first
May 18, 2026
Merged

fix: build CLI before running integration tests#1286
Hweinstock merged 2 commits into
aws:mainfrom
Hweinstock:fix/integ-tests-build-first

Conversation

@Hweinstock
Copy link
Copy Markdown
Contributor

@Hweinstock Hweinstock commented May 18, 2026

Description

Problem

PR fixes two issues:

Solution

  • run build before integ tests.
  • add a script for running e2e tests in dev account. Note: this is separate from run-e2e-local.sh, which attempts to simulate CI locally. run-e2e-dev.sh runs the tests in a dev account, not CI.

Testing

  • npm run test:e2e no longer errors.
  • npm run test:integ runs the integ tests.

Related Issue

N/A

Documentation PR

N/A

Type of Change

  • New feature
  • Other (please describe): Developer workflow improvement — new script for local E2E testing

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

The test:integ script now runs npm run build before vitest to ensure
the latest source changes are included in the built artifact.

Fixes aws#1283
@github-actions github-actions Bot added the size/s PR size: S label May 18, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.13.1.tgz

How to install

npm install https://github.com/aws/agentcore-cli/releases/download/pr-1286-tarball/aws-agentcore-0.13.1.tgz

Copy link
Copy Markdown

@agentcore-cli-automation agentcore-cli-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — small, well-scoped change.

Verified:

  • The test:integ build prefix is correct: integ-tests spawn dist/cli/index.mjs via src/test-utils/cli-runner.ts, so a stale or missing dist/ would silently run an old build (or fail). Adding npm run build && makes npm run test:integ self-contained for local dev. The CI workflow (.github/workflows/build-and-test.yml) already runs npm run build before npm run test:integ, so this introduces a redundant rebuild in CI, but that's negligible.
  • This is consistent with the existing test:tui pattern (npm run build:harness && vitest run --project tui).
  • scripts/run-e2e-dev.sh is a purely additive dev convenience and mirrors the structure of run-e2e-local.sh. The default test (strands-bedrock.test.ts) sensibly only requires Bedrock creds, not the API-key secrets that run-e2e-local.sh fetches.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 18, 2026
@Hweinstock Hweinstock force-pushed the fix/integ-tests-build-first branch from c186f25 to e2c2f67 Compare May 18, 2026 17:50
@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels May 18, 2026
@Hweinstock Hweinstock marked this pull request as ready for review May 18, 2026 17:56
@Hweinstock Hweinstock requested a review from a team May 18, 2026 17:56
@Hweinstock Hweinstock merged commit 306c9e8 into aws:main May 18, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants