fix: build CLI before running integration tests#1286
Merged
Conversation
The test:integ script now runs npm run build before vitest to ensure the latest source changes are included in the built artifact. Fixes aws#1283
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-1286-tarball/aws-agentcore-0.13.1.tgz |
agentcore-cli-automation
approved these changes
May 18, 2026
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM — small, well-scoped change.
Verified:
- The
test:integbuild prefix is correct:integ-testsspawndist/cli/index.mjsviasrc/test-utils/cli-runner.ts, so a stale or missingdist/would silently run an old build (or fail). Addingnpm run build &&makesnpm run test:integself-contained for local dev. The CI workflow (.github/workflows/build-and-test.yml) already runsnpm run buildbeforenpm run test:integ, so this introduces a redundant rebuild in CI, but that's negligible. - This is consistent with the existing
test:tuipattern (npm run build:harness && vitest run --project tui). scripts/run-e2e-dev.shis a purely additive dev convenience and mirrors the structure ofrun-e2e-local.sh. The default test (strands-bedrock.test.ts) sensibly only requires Bedrock creds, not the API-key secrets thatrun-e2e-local.shfetches.
c186f25 to
e2c2f67
Compare
avi-alpert
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
PR fixes two issues:
Solution
run-e2e-local.sh, which attempts to simulate CI locally.run-e2e-dev.shruns the tests in a dev account, not CI.Testing
npm run test:e2eno longer errors.npm run test:integruns the integ tests.Related Issue
N/A
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.