fix: handle scoped conventional commits in changelog categorization#1289
Merged
Merged
Conversation
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-1289-tarball/aws-agentcore-0.14.0.tgz |
agentcore-cli-automation
approved these changes
May 18, 2026
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Looks good to merge. The regexes correctly handle scoped conventional commits (e.g., fix(ci): ...) while still matching the unscoped form, and featuring: style false positives are avoided due to the required : boundary. Small, focused fix to a build script — no serious issues.
avi-alpert
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
categorizeCommitsfunction inscripts/bump-version.tsonly handled non-scoped conventional commits (e.g.,fix: ...,feat: ...). Scoped commits likefix(ci): ...orfeat(auth): ...were incorrectly placed in the "Other Changes" section of the changelog.Replaced
startsWithchecks with regex patterns that match an optional(scope)group.See changelog for examples: https://github.com/aws/agentcore-cli/blob/main/CHANGELOG.md
Related Issue
N/A
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsVerified locally by running
npx tsx scripts/bump-version.ts patchand confirming scoped commits (e.g.,fix(ci): ...) are categorized under "### Fixed" instead of "### Other Changes".Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.