Skip to content

fix: handle scoped conventional commits in changelog categorization#1289

Merged
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:fix/scoped-conventional-commits
May 18, 2026
Merged

fix: handle scoped conventional commits in changelog categorization#1289
Hweinstock merged 1 commit into
aws:mainfrom
Hweinstock:fix/scoped-conventional-commits

Conversation

@Hweinstock
Copy link
Copy Markdown
Contributor

@Hweinstock Hweinstock commented May 18, 2026

Description

The categorizeCommits function in scripts/bump-version.ts only handled non-scoped conventional commits (e.g., fix: ..., feat: ...). Scoped commits like fix(ci): ... or feat(auth): ... were incorrectly placed in the "Other Changes" section of the changelog.

Replaced startsWith checks with regex patterns that match an optional (scope) group.

See changelog for examples: https://github.com/aws/agentcore-cli/blob/main/CHANGELOG.md

Related Issue

N/A

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Verified locally by running npx tsx scripts/bump-version.ts patch and confirming scoped commits (e.g., fix(ci): ...) are categorized under "### Fixed" instead of "### Other Changes".

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added size/xs PR size: XS agentcore-harness-reviewing AgentCore Harness review in progress labels May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.14.0.tgz

How to install

npm install https://github.com/aws/agentcore-cli/releases/download/pr-1289-tarball/aws-agentcore-0.14.0.tgz

Copy link
Copy Markdown

@agentcore-cli-automation agentcore-cli-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. The regexes correctly handle scoped conventional commits (e.g., fix(ci): ...) while still matching the unscoped form, and featuring: style false positives are avoided due to the required : boundary. Small, focused fix to a build script — no serious issues.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 18, 2026
@Hweinstock Hweinstock marked this pull request as ready for review May 18, 2026 18:19
@Hweinstock Hweinstock requested a review from a team May 18, 2026 18:19
@Hweinstock Hweinstock merged commit fc135b0 into aws:main May 18, 2026
25 checks passed
@Hweinstock Hweinstock deleted the fix/scoped-conventional-commits branch May 18, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants