ci(security-review): drop sticky comment, post workflow summary, re-enable synchronize#1293
Merged
Conversation
github-actions
Bot
added
size/xs
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-1293-tarball/aws-agentcore-0.14.0.tgz |
github-actions
Bot
removed
the
claude-security-reviewing
agentcore-cli-automation
approved these changes
May 18, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Docs-only smoke-test PR — looks good to merge.
The added note in CONTRIBUTING.md is accurate: it matches the workflow_dispatch input description in .github/workflows/pr-security-review.yml ("workflow_dispatch will NOT post inline comments — the action only attaches the inline-comment MCP server on PR-context events"). Single sentence, right section, no code/test/telemetry implications. ✅
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Coverage Report
|
…mmary Three changes to verify the inline-comment posting path end-to-end: 1. Add scripts/__sec_review_smoketest.mjs with two deliberate security findings (hardcoded AWS credentials, command injection via exec) so create_inline_comment is actually exercised. 2. Remove instructions to call mcp__github_comment__update_claude_comment from the prompt. That tool requires CLAUDE_COMMENT_ID, which the action only sets in tag mode / when track_progress is enabled. In agent mode it fails. Drop the corresponding entry from --allowedTools too. 3. Add a workflow step that counts buffered findings and posts a single top-level summary comment via the GitHub App token regardless of findings. Replaces the broken sticky-comment path.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
github-actions
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
github-actions
Bot
removed
the
claude-security-reviewing
…ch run) The deliberate findings file was added to exercise the inline-comment posting path. The workflow_dispatch run confirmed the bot correctly identifies both findings (hardcoded AWS credentials, command injection via exec). End-to-end posting via mcp__github_inline_comment__create_inline_comment can only be verified once this PR merges and a follow-up PR triggers pull_request_target — workflow_dispatch produces an AutomationContext where the inline-comment MCP server doesn't register.
tejaskash
changed the title
github-actions
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
github-actions
Bot
removed
the
claude-security-reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tiny doc tweak to test the new
Claude Security Reviewworkflow end-to-end now that #1285 has merged.Adds a one-sentence note in
CONTRIBUTING.mdnoting that the manualworkflow_dispatchpath can verify analysis but cannot post inline comments — the action's inline-comment MCP server only attaches on PR-context events.Test plan
Claude Security Reviewworkflow runs automatically on this PR (maintainer-authored → opens viapull_request_target).mcp__github_inline_comment__create_inline_commenttool, OR posts a "no findings" summary viamcp__github_comment__update_claude_commentif there's nothing to flag on a docs-only diff.GitHubActions-ClaudeSecurityReviewsucceeds.