Skip to content

fix: update PR tarball install instructions to use gh CLI#1307

Merged
jesseturner21 merged 1 commit into
mainfrom
fix-pr-tarball-install-instructions
May 19, 2026
Merged

fix: update PR tarball install instructions to use gh CLI#1307
jesseturner21 merged 1 commit into
mainfrom
fix-pr-tarball-install-instructions

Conversation

@jesseturner21
Copy link
Copy Markdown
Contributor

Summary

  • PR tarball releases are created as drafts, which require authentication to download assets
  • The old npm install <url> command in PR comments didn't work because npm can't auth to GitHub draft releases
  • Updated instructions to use gh release download + npm install -g which handles auth via the gh CLI

Test plan

  • Merge and verify next PR tarball comment shows updated instructions
  • Verify gh release download + npm install -g workflow works for an existing PR tarball

Draft releases require authentication to download assets, so the
`npm install <url>` command doesn't work. Updated instructions to use
`gh release download` which handles auth automatically.
@jesseturner21 jesseturner21 requested a review from a team May 19, 2026 17:34
@github-actions github-actions Bot added the size/xs PR size: XS label May 19, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label May 19, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 19, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.14.0.tgz

How to install

npm install https://github.com/aws/agentcore-cli/releases/download/pr-1307-tarball/aws-agentcore-0.14.0.tgz

Copy link
Copy Markdown

@agentcore-cli-automation agentcore-cli-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The fix correctly addresses the auth issue with draft releases by using gh release download (which authenticates via the gh CLI) followed by npm install -g against the local file. Switching to a global install also matches the pattern documented in the workspace README for testing bundled distributions.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 43.72% 9270 / 21199
🔵 Statements 42.98% 9837 / 22885
🔵 Functions 40.51% 1604 / 3959
🔵 Branches 40.44% 6025 / 14895
Generated in workflow #3107 for commit 55f124e by the Vitest Coverage Report Action

@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 19, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 19, 2026
@jesseturner21 jesseturner21 merged commit e0c2d5b into main May 19, 2026
34 of 36 checks passed
@jesseturner21 jesseturner21 deleted the fix-pr-tarball-install-instructions branch May 19, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants