ci: use GitHub App token for prerelease workflow#1369
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
Package TarballHow to installgh release download pr-1369-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.14.2.tgz |
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Looks good to merge. The change mirrors the GitHub App token pattern already used in release.yml, release-main-and-preview.yml, sync-from-public.yml, sync-preview.yml, and strands-command.yml (same actions/create-github-app-token@v1, same vars.APP_ID / secrets.APP_PRIVATE_KEY), so it's consistent with the rest of the repo. The rationale (default GITHUB_TOKEN lacking access to the private agentcore-l3-cdk-constructs repo during npm run bundle) checks out.
Minor (non-blocking) observation: the top-level permissions: contents: write block is now effectively dead since the release create/delete uses the App token instead of GITHUB_TOKEN. Safe to leave as-is or drop in a follow-up — not worth blocking on.
Description
Switch the prerelease-tarball workflow from
secrets.GITHUB_TOKENto a GitHub App token, consistent with all other workflows in the repo.The default workflow token was insufficient because we need access to the private repo, see: https://github.com/aws/agentcore-cli/actions/runs/26293331790
Related Issue
N/A
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsWorkflow-only change — validated YAML syntax locally.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.