fix(deploy): add harness teardown to TUI deploy flow#1394
Merged
Conversation
The TUI deploy path (useDeployFlow.ts) was missing the imperative harness deployment and teardown logic that exists in the CLI deploy path (actions.ts). This caused "remove all and deploy" to skip harness deletion when run through the TUI. Add post-CDK harness deploy during normal deploys so harness state is persisted to deployed-state.json, and add imperative teardown before stack destroy during teardown deploys. Constraint: Must be gated behind isPreviewEnabled() to match CLI path Rejected: Ungated harness deploy | would expose harness features in GA builds Confidence: high Scope-risk: narrow
github-actions
Bot
added
the
agentcore-harness-reviewing
Contributor
Package TarballHow to installgh release download pr-1394-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.15.0.tgz |
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Coverage Report
|
Contributor
Author
|
Consider folding the remove-all teardown verification into the existing |
Move the remove-all → deploy → verify-deleted assertions from the standalone harness-remove-all.test.ts into createHarnessE2ESuite so all harness e2e tests (bedrock, gemini, openai) verify teardown, saving an entire deploy cycle in CI. Rejected: Keep separate test file | wastes ~10min CI time duplicating deploy Confidence: high Scope-risk: narrow
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
jesseturner21
had a problem deploying
to
e2e-testing
GitHub Actions
Failure
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
… build - Replace separate build+CDK steps with `npm run bundle` which produces both GA and preview tarballs with CDK embedded - GA e2e: install GA tarball, run strands-bedrock baseline + extras - Preview e2e: install preview tarball, run harness-bedrock baseline + extras - Detect helper file changes to trigger all e2e tests Confidence: high Scope-risk: moderate
jesseturner21
force-pushed
the
fix/tui-harness-teardown
branch
from
c692e75 to
61a5f2c
Compare
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
jesseturner21
commented
May 27, 2026
| echo "extra_tests=$CHANGED" >> "$GITHUB_OUTPUT" | ||
| echo "Changed e2e tests: ${CHANGED:-none}" | ||
| # If any helper file changed, run all e2e tests | ||
| HELPERS_CHANGED=$(git diff --name-only "$BASE_SHA"..HEAD -- 'e2e-tests/*.ts' \ |
Contributor
Author
There was a problem hiding this comment.
This changes the e2e tests on pr so that if any helper files change it runs all the tests on the pr. This is important as when people are changing tests we want to see the changes for the tests.
jesseturner21
commented
May 27, 2026
| cfg.modelProvider === 'open_ai' ? 'OpenAI' : cfg.modelProvider === 'gemini' ? 'Gemini' : 'Bedrock'; | ||
|
|
||
| describe.sequential(`e2e: harness/${providerLabel} — create → deploy → invoke`, () => { | ||
| describe.sequential(`e2e: harness/${providerLabel} — create → deploy → invoke → teardown`, () => { |
Contributor
Author
There was a problem hiding this comment.
Add a check in these tests that remove all and deploy actually deletes the harness
Hweinstock
approved these changes
May 27, 2026
| const existingState = await configIO.readDeployedState().catch(() => undefined); | ||
|
|
||
| // Post-CDK: deploy imperative resources (harness) — preview mode only | ||
| let deployedHarnesses: Record<string, HarnessDeployedState> | undefined; |
Contributor
There was a problem hiding this comment.
Since this let is outside the feature flag it becomes dead code in the GA release.
I think this specific pattern isn't very dangerous, but I'm worried this pattern may make it harder to cleanup since the codepaths are no longer isolated.
| const teardownConfigIO = new ConfigIO(); | ||
| const existingTeardownState = await teardownConfigIO | ||
| .readDeployedState() | ||
| .catch(() => ({ targets: {} }) as DeployedState); |
Contributor
There was a problem hiding this comment.
nit: why do we need to cast the type here? is there something we're assuming?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useDeployFlow.ts) was missing imperative harness deployment and teardown logic, causing "remove all and deploy" to skip harness deletiondeployed-state.json)Root Cause
When the feature flag PR (#1341) consolidated preview/main into a single branch, the TUI deploy hook was not updated to include the imperative harness manager calls. The CLI path (
actions.ts) had them butuseDeployFlow.tsdid not.Test plan
ResourceNotFoundExceptionfromget-harnessAPIharness-remove-all.test.ts) passes withBUILD_PREVIEW=1