ci: disable telemetry in e2e and integ test workflows#1421
Merged
Conversation
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Contributor
Package TarballHow to installgh release download pr-1421-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.16.0.tgz |
agentcore-cli-automation
approved these changes
May 28, 2026
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM. Verified:
- Env var name
AGENTCORE_TELEMETRY_DISABLEDmatches whatsrc/cli/telemetry/config.tsreads (line 17). - Value
'1'is correctly interpreted as disabled byresolveTelemetryPreference(only'false','0', or empty enable telemetry). - Scopes are appropriate: workflow-level in
build-and-test.ymlande2e-tests-full.yml(where all jobs need it), job-level on thee2ejob ine2e-tests.yml(theauthorizejob doesn't run the CLI). - Step-level
env:blocks in the test-running steps don't redefineAGENTCORE_TELEMETRY_DISABLED, so the job/workflow-level value is inherited correctly.
No new code or tests, so the telemetry instrumentation and mocking guidance doesn't apply here.
f84328c to
e837b31
Compare
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
e837b31 to
92f7178
Compare
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
Hweinstock
commented
May 28, 2026
| beforeEach(() => tmp.setup()); | ||
| beforeEach(async () => { | ||
| await tmp.setup(); | ||
| delete process.env.AGENTCORE_TELEMETRY_DISABLED; |
Contributor
Author
There was a problem hiding this comment.
the test below is enabling telemetry, then verifying its enabled. Having this env var overrides that, so we delete it for this test scope to keep the original test.
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
avi-alpert
approved these changes
May 29, 2026
jesseturner21
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disables telemetry in CI test workflows by setting
AGENTCORE_TELEMETRY_DISABLED=1in the run environment.Without this, each CI run generates a unique installation ID and emits telemetry as if it were a new customer. This inflates telemetry numbers by treating every CI run as a distinct user, skewing metrics.
Also need to remove integ-tests/telemetry.test.ts since its no longer testable with telemetry disabled. (still covered by unit tests)
Changes:
e2e-tests.yml: job-levelenvon thee2ejobe2e-tests-full.yml: workflow-levelenv(covers bothe2eandbrowser-testsjobs)build-and-test.yml: workflow-levelenv(coversbuildandunit-testjobs)Related Issue
N/A
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.