Skip to content

ci: disable telemetry in e2e and integ test workflows#1421

Merged
jesseturner21 merged 3 commits into
aws:mainfrom
Hweinstock:disable-telemetry-in-ci
May 29, 2026
Merged

ci: disable telemetry in e2e and integ test workflows#1421
jesseturner21 merged 3 commits into
aws:mainfrom
Hweinstock:disable-telemetry-in-ci

Conversation

@Hweinstock
Copy link
Copy Markdown
Contributor

@Hweinstock Hweinstock commented May 28, 2026

Description

Disables telemetry in CI test workflows by setting AGENTCORE_TELEMETRY_DISABLED=1 in the run environment.

Without this, each CI run generates a unique installation ID and emits telemetry as if it were a new customer. This inflates telemetry numbers by treating every CI run as a distinct user, skewing metrics.

Also need to remove integ-tests/telemetry.test.ts since its no longer testable with telemetry disabled. (still covered by unit tests)

Changes:

  • e2e-tests.yml: job-level env on the e2e job
  • e2e-tests-full.yml: workflow-level env (covers both e2e and browser-tests jobs)
  • build-and-test.yml: workflow-level env (covers build and unit-test jobs)

Related Issue

N/A

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe): CI configuration fix to prevent telemetry noise

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added size/xs PR size: XS agentcore-harness-reviewing AgentCore Harness review in progress labels May 28, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 28, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.16.0.tgz

How to install

gh release download pr-1421-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.16.0.tgz

Copy link
Copy Markdown

@agentcore-cli-automation agentcore-cli-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified:

  • Env var name AGENTCORE_TELEMETRY_DISABLED matches what src/cli/telemetry/config.ts reads (line 17).
  • Value '1' is correctly interpreted as disabled by resolveTelemetryPreference (only 'false', '0', or empty enable telemetry).
  • Scopes are appropriate: workflow-level in build-and-test.yml and e2e-tests-full.yml (where all jobs need it), job-level on the e2e job in e2e-tests.yml (the authorize job doesn't run the CLI).
  • Step-level env: blocks in the test-running steps don't redefine AGENTCORE_TELEMETRY_DISABLED, so the job/workflow-level value is inherited correctly.

No new code or tests, so the telemetry instrumentation and mocking guidance doesn't apply here.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 28, 2026
@Hweinstock Hweinstock force-pushed the disable-telemetry-in-ci branch from f84328c to e837b31 Compare May 28, 2026 21:52
@github-actions github-actions Bot added size/xs PR size: XS and removed size/xs PR size: XS labels May 28, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 28, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 28, 2026
@Hweinstock Hweinstock force-pushed the disable-telemetry-in-ci branch from e837b31 to 92f7178 Compare May 28, 2026 21:54
@github-actions github-actions Bot added size/xs PR size: XS and removed size/xs PR size: XS labels May 28, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 28, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 28, 2026
beforeEach(() => tmp.setup());
beforeEach(async () => {
await tmp.setup();
delete process.env.AGENTCORE_TELEMETRY_DISABLED;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test below is enabling telemetry, then verifying its enabled. Having this env var overrides that, so we delete it for this test scope to keep the original test.

@github-actions github-actions Bot added size/s PR size: S and removed size/xs PR size: XS labels May 28, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label May 28, 2026
@agentcore-devx-automation
Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label May 28, 2026
@Hweinstock Hweinstock marked this pull request as ready for review May 28, 2026 22:35
@Hweinstock Hweinstock requested a review from a team May 28, 2026 22:35
@jesseturner21 jesseturner21 merged commit eaa4bcf into aws:main May 29, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants