Skip to content

fix: skip framework/language prompts in BYOC flow#179

Merged
notgitika merged 1 commit into
mainfrom
fix/178-byoc-flow-skip-framework-prompts
Feb 9, 2026
Merged

fix: skip framework/language prompts in BYOC flow#179
notgitika merged 1 commit into
mainfrom
fix/178-byoc-flow-skip-framework-prompts

Conversation

@notgitika
Copy link
Copy Markdown
Contributor

Fixes #178

Description

  • Remove framework and language selection steps from BYOC (Bring Your Own Code) flow
  • These prompts are unnecessary since user's code already has framework/language baked in
  • Show all model providers for BYO (instead of filtering by framework)

Related Issues

#178

Documentation PR

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:all
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

Copy link
Copy Markdown
Contributor

@aidandaly24 aidandaly24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great change

@notgitika notgitika merged commit 622b4ee into main Feb 9, 2026
9 of 14 checks passed
@notgitika notgitika deleted the fix/178-byoc-flow-skip-framework-prompts branch February 9, 2026 14:57
@agentcore-cli-automation
Copy link
Copy Markdown

Reviewed the diff. This is a small, focused change: it removes the language/framework prompts from the BYO wizard and shows all model providers. I verified that mapByoConfigToAgent in useAddAgent.ts does not consume config.language or config.framework, and handleByoPath doesn't either — so the hardcoded 'Python'/'Strands' defaults in handleByoComplete are inert in the BYO path today. The diff correctly also drops Language/Framework from the confirm screen. No serious issues — looks good to merge (and it already is). 👍

jariy17 pushed a commit that referenced this pull request May 21, 2026
Replace secrets.PAT_TOKEN with a short-lived token generated by the
agentcore-devx-automation GitHub App (ID: 3637953) via
actions/create-github-app-token@v1.

This improves security by using ephemeral tokens scoped to the
installation rather than long-lived personal access tokens.

Requires adding repo variable APP_ID=3637953 and repo secret
APP_PRIVATE_KEY with the app's RSA private key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P0] UX - CLI asks to select agent framework etc in BYOC flow

3 participants