Skip to content

fix(tui): improve BYOC flow in add agent (#201)#217

Merged
notgitika merged 4 commits into
mainfrom
fix/201-byoc-flow-improvements
Feb 10, 2026
Merged

fix(tui): improve BYOC flow in add agent (#201)#217
notgitika merged 4 commits into
mainfrom
fix/201-byoc-flow-improvements

Conversation

@notgitika
Copy link
Copy Markdown
Contributor

Fix all issues I mention in issue closes #201

Description

  • Fix Esc key navigation jumping to resource selection instead of previous step by disabling Screen exit handler when sub-components handle their own back navigation
  • Fix codeLocation path missing app/ prefix for BYO agents
  • Create app/<name>/ directory during BYO flow so users have a clear location for their code
  • Show BYO agent code location in success/summary screens with guidance to copy code before deploying
  • Remove incorrect "Python agent (Strands Agents SDK)" label from BYO success screen -- this was a bug

This is the new end of create screen if you add BYO agent....

image

Compare this to earlier in issue: #201

This is interactive add agent in existing project...

image

Related Issues

#201

Documentation PR

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:all
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

- Fix Esc key navigation jumping to resource selection instead of
  previous step by disabling Screen exit handler when sub-components
  handle their own back navigation
- Fix codeLocation path missing app/ prefix for BYO agents
- Create app/<name>/ directory during BYO flow so users have a clear
  location for their code
- Show BYO agent code location in success/summary screens with
  guidance to copy code before deploying
- Remove incorrect "Python agent (Strands Agents SDK)" label from
  BYO success screen
@notgitika notgitika requested a review from a team February 10, 2026 00:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 10, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 7.25% 473 / 6522
🔵 Statements 6.93% 481 / 6939
🔵 Functions 4.25% 57 / 1341
🔵 Branches 5.15% 194 / 3760
Generated in workflow #206 for commit e039290 by the Vitest Coverage Report Action

Comment thread src/cli/commands/add/actions.ts
Comment thread src/cli/tui/screens/add/AddFlow.tsx
Comment thread src/cli/tui/screens/agent/useAddAgent.ts
Comment thread src/cli/tui/screens/create/CreateScreen.tsx
Comment thread src/cli/tui/screens/create/useCreateFlow.ts
notgitika and others added 3 commits February 9, 2026 20:50
…oggin (#193)

* fix: add retry logic for CDK changeset conflicts and improve deploy logging

Fixes #165

* fix: format
The strands-command.yml workflow was failing with MODULE_NOT_FOUND
because the required scripts were not copied when the workflow was added.

Added:
- process-inputs.cjs: Parses /strands commands, determines mode
- agent_runner.py: Main entry point for Strands agent
- github_tools.py: GitHub API tools (issues, PRs, comments)
- handoff_to_user.py: User handoff functionality
- notebook.py: Agent scratchpad
- str_replace_based_edit_tool.py: File editing tool
- task-implementer.sop.md: System prompt for PR mode
- task-refiner.sop.md: System prompt for issue mode
@notgitika
Copy link
Copy Markdown
Contributor Author

notgitika commented Feb 10, 2026

re: Windows compatibility (AI review):

All flagged locations are Windows-safe. Here's why:                                                                                                      
                                                                                                                                                           
  1. join() from Node's path module normalizes separators automatically. join(projectRoot, 'app/MyAgent') produces C:\project\app\MyAgent on Windows.      
  2. replace(/\/$/, '') strips trailing forward slash. The codeLocation value is always stored in agentcore.json with forward slashes (e.g.,               
  "app/MyAgent/") — it's a config convention, not an OS path. The regex strips the trailing / before join() normalizes it to the OS separator.
  3. mkdirSync/mkdir with { recursive: true } works with both path separators on all platforms.
  4. Display paths (CreateScreen.tsx padEnd alignment) use forward slashes (app/MyAgent/) intentionally — this is display text shown to the user, not
  filesystem operations. Forward slashes in display are conventional even on Windows.

  The only theoretical edge case would be if a Windows user manually typed app\MyAgent\ in the TUI, but the default is always set with forward slashes via
  ${APP_DIR}/${name}/, and path.join normalizes regardless.

@notgitika notgitika merged commit 0b0ca42 into main Feb 10, 2026
14 checks passed
@notgitika notgitika deleted the fix/201-byoc-flow-improvements branch February 10, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make BYOC flow better -- couple bugs

3 participants