feat: configurable transaction search index percentage#513
Merged
Conversation
Allow users to configure the Transaction Search indexing percentage via
~/.agentcore/config.json instead of always using 100%. Defaults to 100%
when not specified. Accepts values 0-100.
Example config: { "transactionSearchIndexPercentage": 50 }
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace 4 repeated inline error code/message extractions with the existing getErrorMessage helper and a new isAccessDeniedError helper in errors.ts, addressing PR review feedback. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jesseturner21
temporarily deployed
to
e2e-testing
GitHub Actions
Inactive
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
transactionSearchIndexPercentageoption to the global CLI config (~/.agentcore/config.json) so users can control the X-Ray indexing sampling percentage (0–100, defaults to 100%). Also extracts the repeated AWS error handling pattern (4 occurrences of inlinecode/messageextraction) into a sharedisAccessDeniedErrorhelper inerrors.ts, using the existinggetErrorMessageutility. This addresses PR review feedback from #506.Example config:
{ "transactionSearchIndexPercentage": 50 }Related Issue
Closes #506
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.
🤖 Generated with Claude Code