Conversation
c8f496c to
7f347f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
container-strands-bedrocke2e test fails withEntity expansion limit exceeded: 1015 > 1000during CDK deploy. This is caused byfast-xml-parser5.5.7 introducing a defaultmaxTotalExpansions: 1000limit (as part of CVE-2026-33036 / CVE-2026-33349 fixes), while@aws-sdk/xml-builder@3.972.10does not configure this parameter. Standard XML entity escaping (",&, etc.) in CloudFormation API responses counts toward this limit, and the container deploy template exceeds it.The AWS SDK team fixed this in
@aws-sdk/xml-builder@3.972.14(aws/aws-sdk-js-v3#7867) by settingmaxTotalExpansions: Infinityfor trusted API responses. This PR adds an npm override to pull in the fixed version.Related Issue
Closes #600
Documentation PR
N/A
Type of Change
Testing
Manually triggered workflow on this branch, temporarily adding this test to non-full version, https://github.com/aws/agentcore-cli/actions/runs/23438632117/job/68183188908.
In the future we should make this easier.
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.