Skip to content

fix: add @aws-sdk/xml-builder override to resolve entity expansion limit#601

Merged
notgitika merged 1 commit intoaws:mainfrom
Hweinstock:fix/entity-expansion-limit
Mar 23, 2026
Merged

fix: add @aws-sdk/xml-builder override to resolve entity expansion limit#601
notgitika merged 1 commit intoaws:mainfrom
Hweinstock:fix/entity-expansion-limit

Conversation

@Hweinstock
Copy link
Copy Markdown
Contributor

@Hweinstock Hweinstock commented Mar 23, 2026

Description

The container-strands-bedrock e2e test fails with Entity expansion limit exceeded: 1015 > 1000 during CDK deploy. This is caused by fast-xml-parser 5.5.7 introducing a default maxTotalExpansions: 1000 limit (as part of CVE-2026-33036 / CVE-2026-33349 fixes), while @aws-sdk/xml-builder@3.972.10 does not configure this parameter. Standard XML entity escaping (", &, etc.) in CloudFormation API responses counts toward this limit, and the container deploy template exceeds it.

The AWS SDK team fixed this in @aws-sdk/xml-builder@3.972.14 (aws/aws-sdk-js-v3#7867) by setting maxTotalExpansions: Infinity for trusted API responses. This PR adds an npm override to pull in the fixed version.

Related Issue

Closes #600

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

Manually triggered workflow on this branch, temporarily adding this test to non-full version, https://github.com/aws/agentcore-cli/actions/runs/23438632117/job/68183188908.

In the future we should make this easier.

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions bot added size/xs PR size: XS and removed size/xs PR size: XS labels Mar 23, 2026
@Hweinstock Hweinstock force-pushed the fix/entity-expansion-limit branch from c8f496c to 7f347f0 Compare March 23, 2026 13:14
@github-actions github-actions bot added size/xs PR size: XS and removed size/xs PR size: XS labels Mar 23, 2026
@Hweinstock Hweinstock marked this pull request as ready for review March 23, 2026 13:53
@Hweinstock Hweinstock requested a review from a team March 23, 2026 13:53
Copy link
Copy Markdown
Contributor

@notgitika notgitika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notgitika notgitika merged commit 36f1ca2 into aws:main Mar 23, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: e2e tests failing on main

2 participants