revert: remove CUSTOM strategy and semanticOverride support#713
Merged
aidandaly24 merged 3 commits intomainfrom Mar 27, 2026
Merged
revert: remove CUSTOM strategy and semanticOverride support#713aidandaly24 merged 3 commits intomainfrom
aidandaly24 merged 3 commits intomainfrom
Conversation
Contributor
Package Tarballaws-agentcore-0.3.0-preview.9.0.tgz How to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-713-tarball/aws-agentcore-0.3.0-preview.9.0.tgz |
8327ac7 to
013467b
Compare
jesseturner21
previously approved these changes
Mar 27, 2026
The revert of the CUSTOM strategy commit inadvertently removed the EPISODIC row from the Memory Strategies table in configuration.md.
Contributor
Coverage Report
|
013467b to
ae62347
Compare
jesseturner21
approved these changes
Mar 27, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverts two features that were prematurely merged:
beac707/ feat(memory): add CUSTOM strategy type to agentcore-cli (#677) #694) — removes theCUSTOMstrategy type from the schema, CLI wizards, templates, docs, and validation5e0f584/ feat: add semanticOverride support for SEMANTIC memory strategies #696) — removessemanticOverridefield fromMemoryStrategy, including schemas, types, exports, and cross-field validationEPISODIC strategy support is intentionally preserved throughout.
What changed
MemoryStrategyTypeSchemaenum: 5 → 4 values (removedCUSTOM)SemanticOverrideSchema,SemanticExtractionOverrideSchema,SemanticConsolidationOverrideSchemaand all exportssemanticOverridefield fromMemoryStrategySchemaand.superRefine()cross-field validationcustomoption from create/add-agent wizards and CLI flagsmapExistingMemoriesToProvidersand memory deduplication logiccommands.md,configuration.md,memory.md)configuration.md(inadvertently removed by the CUSTOM revert)Related Issue
Reverts #694, #696
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.