fix: update e2e tests to use --runtime instead of renamed --agent flag#723
Draft
Hweinstock wants to merge 1 commit intoaws:mainfrom
Draft
fix: update e2e tests to use --runtime instead of renamed --agent flag#723Hweinstock wants to merge 1 commit intoaws:mainfrom
Hweinstock wants to merge 1 commit intoaws:mainfrom
Conversation
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-723-tarball/aws-agentcore-0.4.0.tgz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CLI renamed
--agentto--runtimeacross all commands (invoke, logs, traces, status, add online-eval, run eval, evals history), but the e2e tests still use the old--agentflag. This causes all e2e tests to fail witherror: unknown option '--agent'.Solution
Replace all
--agent→--runtimeand--agent-runtime-id→--runtime-idin e2e tests.Testing
Verified each replacement matches the current CLI help output for invoke, logs, traces, status, add online-eval, run eval, and evals history.