fix: use caret range for aws-cdk-lib in project template#805
Merged
fix: use caret range for aws-cdk-lib in project template#805
Conversation
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-805-tarball/aws-agentcore-0.8.0.tgz |
5a656ed to
e7ff5ae
Compare
e7ff5ae to
9769fed
Compare
9769fed to
1471528
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
When the CDK package bumps its
aws-cdk-librequired version, the CLI must manually update its version. This can lead to brief periods where there is an incompatibility between releases/fixes.Solution
Change
aws-cdk-libfrom a pinned version (2.243.0) to a caret range (^2.248.0) so npm can auto-resolve peer dep requirements. This prevents future breakage when the constructs package bumps its cdk-lib minimum.Related Issue
N/A
Documentation PR
N/A
Type of Change
Testing
How have you tested the change?
I ran
npm run test:unitandnpm run test:integI ran
npm run typecheckI ran
npm run lintIf I modified
src/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsagentcore createsucceeds after the change (was failing with ERESOLVE before)Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.