fix: agentcore add component opens component wizard directly#896
Merged
jesseturner21 merged 1 commit intomainfrom Apr 21, 2026
Merged
fix: agentcore add component opens component wizard directly#896jesseturner21 merged 1 commit intomainfrom
jesseturner21 merged 1 commit intomainfrom
Conversation
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-896-tarball/aws-agentcore-0.9.1.tgz |
notgitika
changed the title
When running `agentcore add memory` (or any other component), the TUI was always showing the generic resource selection screen. This is because AddFlow always started in the 'select' state regardless of which subcommand invoked it. Added an `initialResource` prop to AddFlow that maps directly to the correct wizard state, skipping the selection screen. Each primitive now passes its resource type when rendering AddFlow in TUI fallback mode. Closes #857
notgitika
force-pushed
the
fix/add-command-skip-selection-screen
branch
from
d5a63f2 to
4da1348
Compare
Contributor
Coverage Report
|
jesseturner21
approved these changes
Apr 21, 2026
notgitika
added a commit
to notgitika/agentcore-cli
that referenced
this pull request
Apr 24, 2026
…#115) * Add implementation plan for harness Custom JWT auth * fix: agentcore add component opens component wizard directly (aws#896) When running `agentcore add memory` (or any other component), the TUI was always showing the generic resource selection screen. This is because AddFlow always started in the 'select' state regardless of which subcommand invoked it. Added an `initialResource` prop to AddFlow that maps directly to the correct wizard state, skipping the selection screen. Each primitive now passes its resource type when rendering AddFlow in TUI fallback mode. Closes aws#857 * fix(tui): polish harness creation wizard ordering, help text, and summary - Move memory screen first in advanced settings order so it appears before tools when multiple options are selected - Add description help text to all advanced TextInput screens (idle timeout, max lifetime, max iterations, max tokens, timeout, subnets, security groups, session storage) - Add description prop to TextInput component for consistent help text - Add session storage path to the confirm summary screen --------- Co-authored-by: Gitika <53349492+notgitika@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentcore add memory(and all other component subcommands) now opens the component-specific wizard directly instead of showing the generic resource selection screeninitialResourceprop toAddFlowthat maps to the correct wizard state, skipping the selection screenAddFlowin TUI fallback modeRoot Cause
AddFlowalways initialized with{ name: 'select' }state regardless of which subcommand invoked it. The primitives renderedAddFlowwithout telling it which component was requested.Test plan
npx tsc --noEmitpassesagentcore add memory→ should open memory wizard directlyagentcore add agent→ should open agent wizard directlyagentcore add(no subcommand) → should still show selection screenCloses #857