fix: update asset snapshots and fix useDevDeploy skip test#921
Merged
tejaskash merged 1 commit intofeat/harness-implementationfrom Apr 22, 2026
Merged
Conversation
- Update 3 asset snapshots (file listing, cdk/bin/cdk.ts, cdk/lib/cdk-stack.ts) to match current harness-implementation branch content - Fix useDevDeploy test: when skip=true, isComplete is correctly true (skipped means done), not false as the test previously asserted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cdk/bin/cdk.tscdk/lib/cdk-stack.tsuseDevDeploytest: whenskip=true,isCompleteis correctlytrue(skipped = done), notfalseas the test assertedRoot cause
Asset snapshots were not regenerated after harness-related changes to CDK templates and file structure. The
useDevDeploytest had a stale assertion — the hook returnsisComplete = skip || deployDone, so skip=true means immediately complete.Test plan