Skip to content

fix: allow code-based evaluators in online eval configs#947

Merged
jariy17 merged 2 commits intomainfrom
fix/allow-code-based-evaluators-in-online-eval
Apr 24, 2026
Merged

fix: allow code-based evaluators in online eval configs#947
jariy17 merged 2 commits intomainfrom
fix/allow-code-based-evaluators-in-online-eval

Conversation

@jariy17
Copy link
Copy Markdown
Collaborator

@jariy17 jariy17 commented Apr 24, 2026

Summary

Changes

  • OnlineEvalConfigPrimitive: Remove code-based evaluator block in createOnlineEvalConfig()
  • agentcore-project.ts: Remove code-based evaluator validation in schema superRefine
  • AddOnlineEvalFlow.tsx: Remove code-based evaluator filter in TUI evaluator picker

Test plan

  • agentcore add online-eval with a code-based evaluator succeeds (CLI and TUI)
  • agentcore deploy with code-based evaluator in online eval config succeeds
  • Existing LLM-as-a-Judge and Builtin evaluators still work in online eval configs
  • Schema validation passes with code-based evaluators in online eval configs

Remove restrictions that blocked code-based evaluators from being used
in online evaluation configs. The service now supports code-based
evaluators for online evaluation.

Changes:
- Remove code-based evaluator block in OnlineEvalConfigPrimitive
- Remove code-based evaluator validation in schema superRefine
- Remove code-based evaluator filter in TUI evaluator picker
@jariy17 jariy17 requested a review from a team April 24, 2026 17:18
@github-actions github-actions Bot added the size/s PR size: S label Apr 24, 2026
@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.10.0.tgz

How to install

npm install https://github.com/aws/agentcore-cli/releases/download/pr-947-tarball/aws-agentcore-0.10.0.tgz

@jesseturner21
Copy link
Copy Markdown
Contributor

Release coordination concern: the companion CDK PR (aws/agentcore-l3-cdk-constructs#162) is still open and the Lambda-permission fix hasn't been published to npm yet.

Rendered CDK projects depend on @aws/agentcore-cdk from the npm registry (see src/assets/cdk/package.json). If this CLI change ships in a release before a @aws/agentcore-cdk version containing the permission fix is on npm, users who configure a code-based evaluator in an online eval config will hit a deploy-time failure:

does not have permission to access the specified Lambda functions for the Evaluation

A couple of options to mitigate:

  1. Hold this PR until [P0][CLI] Text not cleared when entering second API key #162 is merged and a new @aws/agentcore-cdk version is published, then bump the @aws/agentcore-cdk version pin in src/assets/cdk/package.json as part of (or immediately after) merging this PR so rendered projects pick up the fix.
  2. Land both PRs together and cut a coordinated release (CDK published first, then CLI), again making sure the version pin in src/assets/cdk/package.json requires the fixed CDK version.

Either way, the version pin on @aws/agentcore-cdk should be updated to a version that includes the Lambda-permission change, otherwise existing users on older rendered projects will also silently miss the fix when they regenerate lockfiles.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Apr 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.05% 7245 / 17229
🔵 Statements 41.47% 7679 / 18516
🔵 Functions 40.25% 1288 / 3200
🔵 Branches 40.49% 4824 / 11912
Generated in workflow #1938 for commit 7c1025c by the Vitest Coverage Report Action

@github-actions github-actions Bot added size/s PR size: S and removed size/s PR size: S labels Apr 24, 2026
@jariy17
Copy link
Copy Markdown
Collaborator Author

jariy17 commented Apr 24, 2026

Hey @jesseturner21, we are performing a coordinated release (CDK first, then CLI) since this PR is part of a launch.

Copy link
Copy Markdown
Contributor

@jesseturner21 jesseturner21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cookies

@jariy17 jariy17 merged commit 3d2d671 into main Apr 24, 2026
31 checks passed
@jariy17 jariy17 deleted the fix/allow-code-based-evaluators-in-online-eval branch April 24, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants