Skip to content

test: split browser tests into its own job, fix logs path#975

Merged
avi-alpert merged 1 commit intoaws:mainfrom
avi-alpert:aalpert/fix-browser-e2e
Apr 27, 2026
Merged

test: split browser tests into its own job, fix logs path#975
avi-alpert merged 1 commit intoaws:mainfrom
avi-alpert:aalpert/fix-browser-e2e

Conversation

@avi-alpert
Copy link
Copy Markdown
Contributor

@avi-alpert avi-alpert commented Apr 27, 2026

Description

Split browser tests (Playwright) out of the e2e matrix job into a standalone browser-tests job so they run in parallel with the E2E suite.

Also fixes the failure debug step paths — test-results/browser-tests/test-results/ — so the PTY log and error contexts are actually captured on failure. Previously these pointed to the wrong directory, so failure diagnostics always showed (no pty log).

Related Issue

Closes #

Documentation PR

N/A

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe): CI workflow improvement

Testing

  • Verified the workflow YAML is valid
  • browser-tests job has no needs: dependency, so it runs in parallel with the e2e matrix
  • Browser tests don't use the CDK tarball or API keys from Secrets Manager, so those steps are correctly omitted
  • Debug step paths now match Playwright's outputDir (browser-tests/test-results/)

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@avi-alpert avi-alpert requested a review from a team April 27, 2026 14:29
@github-actions github-actions Bot added size/s PR size: S agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Apr 27, 2026
@avi-alpert avi-alpert merged commit acbfb9e into aws:main Apr 27, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants