Conversation
Contributor
Package TarballHow to installnpm install https://github.com/aws/agentcore-cli/releases/download/pr-996-tarball/aws-agentcore-0.11.0.tgz |
|
Reviewed the change. The fix is correct and minimal — tying One minor semantic observation (not blocking): if a gateway ever does come back from LGTM to merge. |
The refine required both fields to be set together, but resourceName is always needed on import (to preserve the AWS name) while executionRoleArn is only present when the gateway has a custom role. Gateways without a custom role (service auto-creates one) fail the refine because resourceName is set but executionRoleArn is not. Keep the individual field validations (GatewayNameSchema for resourceName, regex for executionRoleArn).
8c017b5 to
2a057ac
Compare
tejaskash
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentcore import gatewayfails for gateways without aroleArnresourceNameandexecutionRoleArnmust co-vary per the schema refine added in feat: add gateway import command with executionRoleArn support #855. When a gateway has noroleArn,resourceNamemust also be omitted to pass validationtoGatewaySpecalways setsresourceNamebut conditionally setsexecutionRoleArn, causing the refine to reject the specTest plan