Add simple test demo for integration testing #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michhyun1
reviewed
Nov 9, 2021
ltrung
reviewed
Nov 9, 2021
ltrung
reviewed
Nov 9, 2021
xuesichao
force-pushed
the
test-demo
branch
6 times, most recently
from
ab61775 to
280221c
Compare
xuesichao
force-pushed
the
test-demo
branch
2 times, most recently
from
1f39a0a to
6f58feb
Compare
ltrung
reviewed
Nov 18, 2021
ltrung
reviewed
Nov 18, 2021
ltrung
reviewed
Nov 18, 2021
ltrung
reviewed
Nov 18, 2021
ltrung
reviewed
Nov 18, 2021
ltrung
reviewed
Nov 18, 2021
ltrung
reviewed
Nov 18, 2021
ltrung
reviewed
Nov 18, 2021
ltrung
reviewed
Nov 18, 2021
michhyun1
reviewed
Nov 18, 2021
michhyun1
reviewed
Nov 19, 2021
michhyun1
reviewed
Nov 19, 2021
michhyun1
reviewed
Nov 19, 2021
michhyun1
reviewed
Nov 19, 2021
jing-chen1
reviewed
Nov 19, 2021
Contributor
jing-chen1
left a comment
jing-chen1
left a comment
There was a problem hiding this comment.
Please use '' for all strings instead of "", React.FC instead of FC and move the import from react to the top
jing-chen1
reviewed
Nov 19, 2021
| > | ||
| <AudioInputControl /> | ||
| <VideoInputControl /> | ||
| <AudioOutputControl /> |
Contributor
There was a problem hiding this comment.
just wonder do we need audio output here, does it change any attendee states?
Contributor
Author
There was a problem hiding this comment.
We don't need it for roster test. But since this is a MeetingControls container, I think it's good to keep it. How do you think?
devalevenkatesh
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
React Component Library is lack of integration testing coverage.
Description of changes:
Create a simple demo App under
/integrationfolder.This simple demo has a main page which serves as a menu. We could reuse the component and container to quickly build a simple test demo according to testing requirement. This menu could redirects the App to the specific test demo to do the testing.
Some screenshots for review
Home
Roster Test App - Before Joining
Roster Test App - After Joining
Testing
Have you successfully run
npm run build:releaselocally?Yes
How did you test these changes?
Try the basic e2e testing and make sure the demo works well.
If you made changes to the component library, have you provided corresponding documentation changes?
Yes, in CHANGELOG. And create a simple README to guide on adding new test demo.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.