Use environment variables for workflow inputs #1971
Merged
+102
−53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The GitHub Actions workflows use inconsistent patterns for handling workflow inputs. Some workflows directly interpolate
${{ inputs.* }}values in shell commands, while others use the recommendedenv:block pattern. This inconsistency makes the codebase harder to maintain and doesn't follow GitHub Actions best practices.Description of changes
Standardized input handling across 9 workflow files to use the
env:block pattern:test-artifacts.ymlinputs.test_repo_branchandinputs.build_idto env variablesintegration-test.ymlinputs.build_shato env variableapplication-signals-e2e-test.ymlinputs.build_shato env variablerelease-candidate-test.ymlinputs.test_repo_branchto env variablerepackage-release-artifacts.ymlinputs.build_idto env variable across 4 stepsupload-dependencies.ymlinputs.s3_integration_bucketandinputs.github_shato env variableseks-performance-cluster-addon-install.ymlwd-integration-test.ymlinputs.build_shato env variabletest-build.ymlinputs.Bucketandinputs.BucketKeyto env variablesThe pattern change:
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.