Send agent overhead values as int #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are currently sending the `memory_usage_mb` and `timeInMs` fields in the agent overhead metadata, unfortunately the schema for those is INT which means they are currently discarded when the profile is validated at submission time. This does not prevent profiles from being accepted but we lose the overhead data which means we will not show it in the UI. This change converts them to int before we serialize the report. It would be nice for the backend to accept decimals at least for the memory since it is in MB and we may often be under 1MB. But at the moment it is better to align to current schema.
PapaPedro
force-pushed
the
fix_agent_overhead_format
branch
from
c145034 to
cca9d6c
Compare
mirelap-amazon
approved these changes
Jul 21, 2021
| }, | ||
| "agentOverhead": { | ||
| "memory_usage_mb": memory_usage_mb | ||
| "memory_usage_mb": int(memory_usage_mb) |
Contributor
There was a problem hiding this comment.
Should this be memoryInMB
Contributor
There was a problem hiding this comment.
I just checked the internal schema and that's right, I'll update, thanks for noticing this.
mukileshPira
approved these changes
Jul 27, 2021
mirelap-amazon
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently sending the
memory_usage_mbandtimeInMsfields inthe agent overhead metadata, unfortunately the schema for those is INT
which means they are currently discarded when the profile is validated
at submission time. This does not prevent profiles from being accepted
but we lose the overhead data which means we will not show it in the UI.
This change converts them to int before we serialize the report.
It would be nice for the backend to accept decimals at least for the
memory since it is in MB and we may often be under 1MB. But at the
moment it is better to align to current schema.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.