Skip to content

Conversation

@bwagner5
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:

  • Prevent caching when downloading the github release assets by setting the no-cache header and an arbitrary query string
  • Sync to homebrew tap AFTER the release assets have been uploaded :)
  • Fix remote origin to use fork instead of actual repo

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #31 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   90.05%   89.82%   -0.23%     
==========================================
  Files           8        8              
  Lines         875      875              
==========================================
- Hits          788      786       -2     
- Misses         57       58       +1     
- Partials       30       31       +1     
Impacted Files Coverage Δ
pkg/selector/selector.go 84.36% <0.00%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c446a12...8dbc639. Read the comment docs.

@bwagner5 bwagner5 requested a review from brycahta July 15, 2020 23:09
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cache money 👍🏼

@bwagner5 bwagner5 merged commit 5df83d2 into aws:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants