Skip to content

Conversation

@bwagner5
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:

  • added float64 comparisons back since they were used for vcpus-to-memory-ratio comparisons
  • fixed table wide output labels for memory and gpu memory from MiB to GiB

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #40 into master will decrease coverage by 0.52%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   88.90%   88.38%   -0.53%     
==========================================
  Files           9        9              
  Lines        1055     1068      +13     
==========================================
+ Hits          938      944       +6     
- Misses         81       88       +7     
  Partials       36       36              
Impacted Files Coverage Δ
pkg/selector/selector.go 81.97% <0.00%> (-2.54%) ⬇️
pkg/selector/comparators.go 92.04% <100.00%> (+0.58%) ⬆️
pkg/selector/outputs/outputs.go 91.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80cb0b3...2020037. Read the comment docs.

@bwagner5 bwagner5 requested a review from brycahta July 29, 2020 17:47
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here look good 👍🏼

While on the topic of ratio, there's a comment in calculateVCpusToMemoryRatio:

// normalize vcpus to a mebivcpu value

Should this still be mebivcpu even though the ratio is using GiB?

@bwagner5
Copy link
Contributor Author

yep, should still be mebivcpus because it is still stored in MebiBytes, the input just defaults to GiB

@bwagner5 bwagner5 merged commit a67979b into aws:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants