Implement IMDS scanner for task credential retrieval#4945
Merged
Conversation
82f2206 to
45464f0
Compare
mye956
reviewed
Apr 29, 2026
mye956
reviewed
Apr 29, 2026
mye956
reviewed
Apr 29, 2026
mye956
previously approved these changes
Apr 29, 2026
- Implement Scanner.Scan() to discover iam-ecs-* namespaces, read info files, and fetch credentials - Add rate limiter (~10% of IMDS PPS budget) to leave headroom for other link-local requests on the instance - Cache LastUpdated per namespace to optimize IMDS call volume
mye956
approved these changes
Apr 29, 2026
ShelbyZ
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the IMDS credential scanner in the shared library (
ecs-agent/credentials/imds). The scanner discoversiam-ecs-*IMDS namespaces, reads their info files, and fetches task credentials with rate limiting. The scanner is not used by the ECS agents today, and the feature is config-disabled.Changes to consume this shared library will come in a follow-up PR. Changes to incorporate metrics in the scanner will also come in a follow-up PR after operational review for the feature.
Implementation details
Testing
New tests cover the changes: yes, added new unit tests
Description for the changelog
Feature - Implement IMDS scanner for task credential retrieval, in the shared library
Additional Information
Does this PR include breaking model changes? No
Does this PR include the addition of new environment variables in the README? No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.