This repository was archived by the owner on Nov 19, 2025. It is now read-only.
Regcreds #652
Merged
Regcreds #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoManyHs
reviewed
Oct 25, 2018
Contributor
SoManyHs
left a comment
SoManyHs
left a comment
There was a problem hiding this comment.
Would it be possible to squash the "Address comments" commits at least? I don't mind keeping this in multiple commits in general -- I'd also consider merging this as a merge commit so it's clear that this is all part of one feature.
PettitWesley
approved these changes
Oct 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.