This repository was archived by the owner on May 31, 2024. It is now read-only.
fix: fixing monocdk imports#190
Merged
Merged
Conversation
elliot-smith
approved these changes
Nov 24, 2021
IllyaYalovyy
approved these changes
Nov 24, 2021
nbraid
reviewed
Nov 24, 2021
Contributor
nbraid
left a comment
nbraid
left a comment
There was a problem hiding this comment.
I saw in the announcement email that: "Going forward, we will be taking steps to prevent these deep imports from being possible in the first place in order to prevent future uintended misuse"
Would it make sense to add a check to prevent these imports from being added in the future? e.g. https://eslint.org/docs/rules/no-restricted-imports Or do we think this will be unnecessary in future versions if the CDK team ends up fixing this?
AndreyDovydenko
added a commit
that referenced
this pull request
Nov 24, 2021
Closed
4 tasks
nbraid
pushed a commit
that referenced
this pull request
Nov 24, 2021
AndreyDovydenko
added a commit
that referenced
this pull request
Nov 25, 2021
* fix: fixing monocdk imports (#190) * chore(release): 1.1.2 Co-authored-by: Andrey Dovydenko <dovydenk@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: fixing monocdk imports
Description of Changes
[//]: # one of the recent monocdk npm packages have restructured the file tree inside the package, changing the import calls from our code to be agnostic of that change.
Description of how you validated changes
[//]: # Ran
npm run buildto verify the new import calls are working fineChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license