This repository was archived by the owner on May 31, 2024. It is now read-only.
feat: stop discarding un-actionable deployment errors#270
Merged
Conversation
Not having a Docker repository exist was a non-actionable error, and so it would result in a message saying that contexts failed to deploy because one or more contexts failed to deploy. This should aggregate even non-actionable errors into something that might, in fact, be actionable.
elliot-smith
approved these changes
Jan 25, 2022
samwaln
approved these changes
Feb 9, 2022
markjschreiber
approved these changes
Feb 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of Changes
Not having a Docker repository exist was a non-actionable error, and so it
would result in a message saying that contexts failed to deploy because one or
more contexts failed to deploy.
This should aggregate even non-actionable errors into something that might, in
fact, be actionable.
Description of how you validated changes
Validated by re-running a failing deployment and noting that an error message was printed referring to the underlying error.
Checklist
I haven't done this; none of this UI stuff appears to be under test at the moment, so there's no test to edit to match the new output.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license