This repository was archived by the owner on May 31, 2024. It is now read-only.
feat: Add JSON as a CLI output format (#215)#309
Merged
Merged
Conversation
tneely
suggested changes
Feb 7, 2022
| return fmt.Errorf("a single format value must be provided") | ||
| } | ||
| format := format.FormatterType(o.formatContextVars.format) | ||
| format := format.FormatterType(args[0]) |
Contributor
There was a problem hiding this comment.
Can you please pull the args[0] value into a meaningful variable, especially since we reuse it across the code?
Contributor
Author
There was a problem hiding this comment.
We aren't actually using args[0] within the same function
First we validate the args within Validate(args) then we pull out args[0] and assign it to opts.format
tneely
approved these changes
Feb 7, 2022
samwaln
approved these changes
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #215
Description of Changes
agc configure formatcommand as that was never working as-is.Description of how you validated changes
Added unit tests
Testing
agc configure formatmanuallytested json output of other commands can be seen in this doc: https://quip-amazon.com/klA5AaAOPF62/agc-json-format
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license