Skip to content

Fix potential memory visibility bug #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taldekar merged 2 commits into from
Feb 14, 2025
Merged

Fix potential memory visibility bug #367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea73262
Fix thread visibility bug
taldekar Feb 13, 2025
50b7e7a
Fix thread visibility bug
taldekar Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions plugin/src/software/aws/toolkits/eclipse/amazonq/views/AmazonQViewContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import org.eclipse.swt.widgets.Display;
import org.eclipse.ui.part.ViewPart;

import io.reactivex.rxjava3.disposables.Disposable;
import software.aws.toolkits.eclipse.amazonq.broker.api.EventObserver;
import software.aws.toolkits.eclipse.amazonq.plugin.Activator;
import software.aws.toolkits.eclipse.amazonq.views.actions.AmazonQStaticActions;
Expand All @@ -26,11 +25,10 @@ public final class AmazonQViewContainer extends ViewPart implements EventObserve
public static final String ID = "software.aws.toolkits.eclipse.amazonq.views.AmazonQViewContainer";

private Composite parentComposite;
private StackLayout layout;
private volatile StackLayout layout;
private Map<AmazonQViewType, BaseAmazonQView> views;
private AmazonQViewType activeViewType;
private BaseAmazonQView currentView;
private Disposable activeViewTypeSubscription;
private volatile AmazonQViewType activeViewType;
private volatile BaseAmazonQView currentView;
private final ReentrantLock containerLock;

public AmazonQViewContainer() {
Expand Down