Skip to content

Trigger LSP configuration pull on preference update #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
breedloj merged 2 commits into from
Mar 6, 2025
Merged

Trigger LSP configuration pull on preference update #388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81e2197
Trigger LSP configuration pull on preference update
breedloj Mar 5, 2025
e417a7c
Merge branch 'main' into breedloj-patch-4
breedloj Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions plugin/src/software/aws/toolkits/eclipse/amazonq/preferences/AmazonQPreferencePage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@
import org.eclipse.ui.IWorkbench;
import org.eclipse.ui.IWorkbenchPreferencePage;

import software.aws.toolkits.eclipse.amazonq.customization.CustomizationUtil;
import software.aws.toolkits.eclipse.amazonq.lsp.auth.model.LoginType;
import software.aws.toolkits.eclipse.amazonq.lsp.model.GetConfigurationFromServerParams;
import software.aws.toolkits.eclipse.amazonq.plugin.Activator;
import software.aws.toolkits.eclipse.amazonq.telemetry.AwsTelemetryProvider;
import software.aws.toolkits.eclipse.amazonq.telemetry.UiTelemetryProvider;
import software.aws.toolkits.eclipse.amazonq.util.PluginUtils;
import software.aws.toolkits.eclipse.amazonq.util.ThreadingUtils;

public class AmazonQPreferencePage extends FieldEditorPreferencePage implements IWorkbenchPreferencePage {
public static final String PREFERENCE_STORE_ID = "software.aws.toolkits.eclipse.preferences";
Expand Down Expand Up @@ -265,6 +267,7 @@ private void sendUpdatedPreferences() {
changedDataSharingOptInChecked.toString());
isQDataSharingOptInChecked = changedDataSharingOptInChecked;
}
ThreadingUtils.executeAsyncTask(() -> CustomizationUtil.triggerChangeConfigurationNotification());
Copy link
Copy Markdown

@rli rli Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really specific to customization

}

@Override
Expand Down