add support for Windows prefix delegation #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated IP provider to support resource group * fixed importing constants from a different package
…econstructed IPs (aws#212) * added new resource type and IP allocation workflow for prefix IPs * added API to return resource provider by resource name and unit tests
…xes from EC2 (aws#219) * modified eni manager to allocate and deallocate IPv4 prefixes from EC2 * added unit tests and updated mocks for eni manager and ec2 helper * refactored ip resource count and return values
aws#220) * updated warm pool to support resource group for secondary ip and prefix-ip * added default config for prefix-ip warm pool * fixed deleting group from warm resource and updated existing pool tests * refactored helper functions and added unit tests for warmpool * refactored helper functions and added unit tests for warmpool * added APIs to set pool status to active or draining
…ng workflow build (aws#222) * updated secondary ip provider unit tests * fixed ip provider and unit tests with updated eni API * commented out prefix provider to get existing workflow built * minor fix to make it build
* added support for loading PD configuration from config map * added prefix provider to manage ipv4 prefixes as a new resource * updated pool to set PD configs to default if not valid * added logger to log failures when parsing PD configs
…s#240) added a check for nitro status when toggling from PD to secondary IP and refactored common code for nitro check
sushrk
reviewed
Jun 7, 2023
Contributor
sushrk
left a comment
sushrk
left a comment
There was a problem hiding this comment.
LGTM, all the commits have been previously approved in windows-prefix-delegation branch.
Adding a comment to give others a chance to review before approving. Thanks @jiechen0826 !
Contributor
|
lgtm. |
sushrk
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.