Skip to content

Conversation

@ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Jun 9, 2023

Issue #, if available:

Description of changes:

  • Added a DEVELOPER_GUIDE
  • Use ko for image builds, improving build times from 10 minutes -> 23 seconds (on OSX)
  • Introduce a presubmit target, which executes all steps in the dev workflow
  • Introduce a toolchain target, which automatically installs all tools required for development (verified in presubmit)
  • Includes controller-gen in presubmit, to enforce CRD to be up to date

Local Controller takes lease

make apply

k get lease cp-vpc-resource-controller -n kube-system -oyaml
apiVersion: coordination.k8s.io/v1
kind: Lease
metadata:
  creationTimestamp: "2022-12-23T10:23:14Z"
  name: cp-vpc-resource-controller
  namespace: kube-system
  resourceVersion: "62722223"
  uid: 8817e6d3-019a-4068-b363-aea4dc9a2daa
spec:
  acquireTime: "2023-06-29T18:36:56.000000Z"
  holderIdentity: vpc-resource-local-controller-574d58d89c-dmkp4_86162373-4d94-43a7-97b2-275d56dede83
  leaseDurationSeconds: 30
  leaseTransitions: 32
  renewTime: "2023-06-29T18:37:21.585152Z"

Controller resumes lease

make delete
k get lease cp-vpc-resource-controller -n kube-system -oyaml

apiVersion: coordination.k8s.io/v1
kind: Lease
metadata:
  creationTimestamp: "2022-12-23T10:23:14Z"
  name: cp-vpc-resource-controller
  namespace: kube-system
  resourceVersion: "62721552"
  uid: 8817e6d3-019a-4068-b363-aea4dc9a2daa
spec:
  acquireTime: "2023-06-29T18:33:26.744612Z"
  holderIdentity: ip-10-0-54-3.us-west-2.compute.internal_3159b31f-49d3-42f5-9d6e-36fd56a34566
  leaseDurationSeconds: 30
  leaseTransitions: 32
  renewTime: "2023-06-29T18:35:01.890293Z"```


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ellistarn ellistarn requested a review from a team as a code owner June 9, 2023 19:55
@ellistarn ellistarn force-pushed the make branch 13 times, most recently from 7fbc3e7 to 89e90c8 Compare June 9, 2023 23:16
@ellistarn ellistarn force-pushed the make branch 5 times, most recently from d4bd275 to 6850375 Compare June 29, 2023 18:47
@ellistarn ellistarn force-pushed the make branch 5 times, most recently from 1696349 to d02c57b Compare June 30, 2023 16:43
Copy link
Contributor

@haouc haouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the wonderful improvement. It is much faster for dev.

@ellistarn ellistarn merged commit a19a933 into aws:master Jun 30, 2023
@ellistarn ellistarn deleted the make branch June 30, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants