Skip to content

handle nested exceptions in exception handlers #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
+4 −4
Merged

handle nested exceptions in exception handlers #1605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion wrapper/src/main/java/software/amazon/jdbc/exceptions/AbstractPgExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public boolean isNetworkException(final Throwable throwable, @Nullable TargetDri
if (exception instanceof SQLException) {
return isNetworkException(((SQLException) exception).getSQLState());
} else if (targetDriverDialect != null) {
String sqlState = targetDriverDialect.getSQLState(throwable);
String sqlState = targetDriverDialect.getSQLState(exception);
if (!StringUtils.isNullOrEmpty(sqlState)) {
return isNetworkException(sqlState);
}
Expand Down
4 changes: 2 additions & 2 deletions wrapper/src/main/java/software/amazon/jdbc/exceptions/GenericExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public boolean isNetworkException(final Throwable throwable, @Nullable TargetDri
if (exception instanceof SQLException) {
return isNetworkException(((SQLException) exception).getSQLState());
} else if (targetDriverDialect != null) {
String sqlState = targetDriverDialect.getSQLState(throwable);
String sqlState = targetDriverDialect.getSQLState(exception);
if (!StringUtils.isNullOrEmpty(sqlState)) {
return isNetworkException(sqlState);
}
Expand Down Expand Up @@ -98,7 +98,7 @@ public boolean isLoginException(final Throwable throwable, TargetDriverDialect t
if (exception instanceof SQLException) {
sqlState = ((SQLException) exception).getSQLState();
} else if (targetDriverDialect != null) {
sqlState = targetDriverDialect.getSQLState(throwable);
sqlState = targetDriverDialect.getSQLState(exception);
}

if (isLoginException(sqlState)) {
Expand Down
2 changes: 1 addition & 1 deletion wrapper/src/main/java/software/amazon/jdbc/exceptions/MySQLExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public boolean isNetworkException(final Throwable throwable, @Nullable TargetDri
return true;
}
} else if (targetDriverDialect != null) {
String sqlState = targetDriverDialect.getSQLState(throwable);
String sqlState = targetDriverDialect.getSQLState(exception);
if (!StringUtils.isNullOrEmpty(sqlState)) {
return isNetworkException(sqlState);
}
Expand Down
Loading