docs: Remove reader load balancing from readme and benchmark results #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyc-bq
changed the title
congoamz
reviewed
Apr 22, 2023
| The diagram in this section shows the AWS JDBC Driver's performance when using the read-write splitting plugin. This test sets up a large number of connections in parallel; the initial connection is to the writer. The test executes a long query many times to simulate heavy queries. | ||
|
|
||
| The average overhead time is measured as the average time difference between running the entire test with the read-write plugin and running the entire test without any plugins. The baseline overhead time is 0 because there are no plugins in this scenario and thus there is no plugin overhead. | ||
|
|
Contributor
There was a problem hiding this comment.
We will have to change the connected image as well since it has a bar for r/w with load balancing. Remind me where the test code for these results? I'm not sure if we should run the test with internal connection pooling instead of load balancing
Contributor
|
Can you remove the change to docs/images/jdbc_wrapper_init_release_pipelines_benchmarks.png? I already replaced this image in #359 and included performance results from using internal connection pools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reader load balancing benchmark results removed from readme