add connect exception handling to IAM plugin #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return connectFunc.call(); | ||
| } catch (final SQLException exception) { | ||
|
|
||
| LOGGER.finest( |
Contributor
There was a problem hiding this comment.
Nitpick: Would it also be worth logging the token as well? Or not necessary?
karenc-bq
approved these changes
May 20, 2023
karenc-bq
reviewed
May 20, 2023
Comment on lines
+168
to
+169
| if (!this.pluginService.isLoginException(exception) || !isCachedToken) { | ||
| throw exception; |
Contributor
There was a problem hiding this comment.
Agreed with Aaron, can we log the token and isCachedToken if it is a login exception. Would be beneficial for debugging purposes
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add connect exception handling to IAM plugin
Additional Reviewers
@karenc-bq
@aaron-congo
@hsuamz
@aaronchung-bitquill
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.