Skip to content

Conversation

@karenc-bq
Copy link
Contributor

Summary

sample code for using the driver with:

  • spring and hibernate
  • spring and wildfly

Description

Additional Reviewers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

CHANGELOG.md Outdated
- Elastic Load Balancer URL support ([PR#476](https://github.com/awslabs/aws-advanced-jdbc-wrapper/pull/476)).
- Sample code and tutorial for using the driver with:
- Spring and Hibernate
- Spring and Wildfly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add links to the readme files?

@@ -0,0 +1,180 @@
# Tutorial: Getting Started with the AWS Advanced JDBC Wrapper, Spring Boot and Hibernate

In this tutorial, you will set up a String Boot and Hibernate application with the AWS Advanced JDBC Wrapper, and use the IAM Authentication plugin to fetch some data from an Aurora PostgreSQL database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS Advanced JDBC Driver?

@@ -0,0 +1,23 @@
spring:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files are missing copyright notices, do they need them?

@karenc-bq karenc-bq force-pushed the spring_wildfly branch 2 times, most recently from 5c93028 to 5871ee7 Compare June 14, 2023 18:54
@karenc-bq karenc-bq merged commit 8b9b22d into aws:main Jun 14, 2023
@karenc-bq karenc-bq deleted the spring_wildfly branch June 14, 2023 22:43

This example contains some very simple configurations for the IAM Authentication plugin, if you are interested in other configurations related to failover, please visit [the documentation for failover parameters](../../docs/using-the-jdbc-driver/using-plugins/UsingTheFailoverPlugin.md#failover-parameters)
2. Configure Hibernate dialect:
```properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this block labeled a properties block instead of a yaml block?

├───amazon
│ └───standalone.xml
```
> Note: The wildfly directory will contain all the files you have downloaded in step 3. For simplicity, the diagram above only shows the files requiring modifications or need to be added.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Note: The wildfly directory will contain all the files you have downloaded in step 3. For simplicity, the diagram above only shows the files requiring modifications or need to be added.
> Note: The wildfly directory will contain all the files that you will download in step 3. For simplicity, the diagram above only shows the files that either need to be added or require modifications.

private static final String MYSQL_CONTAINER_IMAGE_NAME = "mysql:latest";
private static final String POSTGRES_CONTAINER_IMAGE_NAME = "postgres:latest";
private static final String MARIADB_CONTAINER_IMAGE_NAME = "mariadb:latest";
private static final String MARIADB_CONTAINER_IMAGE_NAME = "mariadb:10";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why are we changing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest tag was updated 5 days ago to point to mariadb v11, and standard integration tests are failing.
Since we are close to the release we are changing the tag to v10 for now.

<remote-destination host="${jboss.mail.server.host:localhost}" port="${jboss.mail.server.port:25}"/>
</outbound-socket-binding>
</socket-binding-group>
</server> No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing newline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants