feat: custom endpoint plugin#369

Merged

crystall-bitquill merged 1 commit intomainfrom

feat/custom-endpoints

Feb 12, 2025

Contributor

crystall-bitquill commented Jan 14, 2025 •

edited

Loading

Summary

Custom Endpoint Plugin

Description

Adds the custom endpoint plugin
Implements setAvailability in PluginService
Moves getRegion in the IamAuthUtils to RegionUtils
Fixes the MySQL database dialect getHostRole method - previously the query result was not being parsed correctly
Adds method to set the reader failover handler enableFailoverStrictReader value - previously it was always false.
Fixes incorrect check in the reader failover handler where a writer host would be returned even if the failover mode was set to strict reader
Moved the rdsHostListProvider's isDialectTopologyAware method to the utils file
Adds a check in the MySQL and PG Clients after creating a connection to confirm the host role, which can't always be identified correctly with just the provided host.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

crystall-bitquill force-pushed the feat/custom-endpoints branch from 6698fb5 to 1c989bc Compare

January 14, 2025 19:42

crystall-bitquill added the ready for review label

crystall-bitquill force-pushed the feat/custom-endpoints branch from 1c989bc to 67a7625 Compare

January 14, 2025 21:20

karenc-bq reviewed

View reviewed changes

common/lib/utils/region_utils.ts

karenc-bq reviewed

View reviewed changes

common/lib/utils/region_utils.ts Outdated

karenc-bq reviewed

View reviewed changes

common/lib/utils/region_utils.ts

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_info.ts Outdated

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_info.ts Outdated

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_info.ts Outdated

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_info.ts Outdated

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_info.ts Outdated

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_info.ts Outdated

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_plugin.ts

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_plugin.ts Outdated

karenc-bq reviewed

View reviewed changes

common/lib/utils/locales/en.json Outdated

karenc-bq reviewed

View reviewed changes

common/lib/utils/rds_utils.ts Outdated

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_monitor_impl.ts

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_monitor_impl.ts Outdated

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_monitor_impl.ts Outdated

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_role_type.ts Outdated

karenc-bq reviewed

View reviewed changes

tests/integration/container/tests/custom_endpoint.test.ts

+                afterEach(async () => {
+                  if (client !== null) {
+                    try {
+                      await client.end();

Contributor

karenc-bq Jan 15, 2025

Do we need to clear the cache each test run via PluginManager.releaseResources()

Contributor Author

crystall-bitquill Jan 15, 2025

Yes, releaseResources is called below this line

crystall-bitquill force-pushed the feat/custom-endpoints branch from 67a7625 to 07e6851 Compare

January 16, 2025 21:42

karenc-bq reviewed

View reviewed changes

common/lib/plugins/custom_endpoint/custom_endpoint_monitor.ts Outdated

crystall-bitquill force-pushed the feat/custom-endpoints branch 7 times, most recently from 33a53d9 to ce12cb4 Compare

January 24, 2025 00:57

crystall-bitquill force-pushed the feat/custom-endpoints branch from ce12cb4 to ef4288d Compare

January 27, 2025 23:37

crystall-bitquill requested a review from a team as a code owner

January 27, 2025 23:37

crystall-bitquill force-pushed the feat/custom-endpoints branch from ef4288d to 6d4363e Compare

January 27, 2025 23:58

karenc-bq reviewed

View reviewed changes

common/lib/host_list_provider/rds_host_list_provider.ts Outdated

common/lib/plugin_service.ts Outdated

common/lib/plugin_service.ts Outdated

common/lib/plugin_service.ts Outdated

common/lib/plugins/custom_endpoint/custom_endpoint_monitor_impl.ts Outdated

common/lib/plugins/custom_endpoint/custom_endpoint_monitor_impl.ts Outdated

common/lib/plugins/failover/failover_plugin.ts Outdated

common/lib/plugins/failover/failover_plugin.ts

crystall-bitquill force-pushed the feat/custom-endpoints branch 4 times, most recently from 33d730d to 1b72add Compare

January 30, 2025 21:25

karenc-bq reviewed

View reviewed changes

common/lib/plugins/failover/failover_plugin.ts Outdated

crystall-bitquill force-pushed the feat/custom-endpoints branch from 1b72add to 33487f3 Compare

January 31, 2025 00:50

karenc-bq approved these changes

View reviewed changes

crystall-bitquill force-pushed the feat/custom-endpoints branch 9 times, most recently from e977dbd to 11c4155 Compare

February 4, 2025 02:42

karenc-bq reviewed

View reviewed changes

common/lib/plugin_service.ts Outdated

karenc-bq approved these changes

View reviewed changes

crystall-bitquill force-pushed the feat/custom-endpoints branch 3 times, most recently from 3d1a9c6 to 150ff62 Compare

February 10, 2025 18:28


          feat: custom endpoint plugin

59f9ed8

crystall-bitquill force-pushed the feat/custom-endpoints branch from 150ff62 to 59f9ed8 Compare

February 12, 2025 08:02

joyc-bq approved these changes

View reviewed changes

crystall-bitquill merged commit 068e0c0 into main

crystall-bitquill deleted the feat/custom-endpoints branch

February 12, 2025 18:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review