Skip to content

Conversation

@zijun726911
Copy link
Contributor

As we recently changed the method to read Config file in
#264

We need to explicitly do config.ConfigInit() when create the test framework

Test

  • Did the fmt.Println("config.Region: ", config.Region), it could read the correct config.Region
  • make e2etest all can pass
• [253.448 seconds]
------------------------------

Ran 3 of 3 Specs in 769.177 seconds
SUCCESS! -- 3 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIntegration (769.41s)
PASS
ok  	github.com/aws/aws-application-networking-k8s/test/suites/integration	770.031s

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5224226412

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 32.439%

Totals Coverage Status
Change from base Build 5160371473: 0.0%
Covered Lines: 3275
Relevant Lines: 10096

💛 - Coveralls

var scheme = scheme.Scheme
lo.Must0(v1beta1.Install(scheme))
lo.Must0(v1alpha1.Install(scheme))
config.ConfigInit()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't it work before without config.ConfigInit?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. Controller and e2etest frame work are in two different processes.

@zijun726911 zijun726911 merged commit 65ea9cf into aws:main Jun 9, 2023
@zijun726911 zijun726911 deleted the set-testframework-region-config branch September 27, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants