generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 71
Add mapper.policyToTargetRefObj() helper function #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zijun726911
merged 3 commits into
aws:main
from
zijun726911:security-group-api-support-1
Sep 20, 2023
Merged
Add mapper.policyToTargetRefObj() helper function #398
zijun726911
merged 3 commits into
aws:main
from
zijun726911:security-group-api-support-1
Sep 20, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f361809 to
c65e977
Compare
- Add vpcAssociationPolicyEventHandler.MapToGateway() method - Make gateway_controller optionally watches the `VpcAssociationPolicy`
c65e977 to
aaffb2a
Compare
scottlaiaws
reviewed
Sep 18, 2023
Pull Request Test Coverage Report for Build 6240134816
💛 - Coveralls |
scottlaiaws
approved these changes
Sep 19, 2023
Contributor
scottlaiaws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
solmonk
reviewed
Sep 19, 2023
f5d2fc0 to
1c5e222
Compare
solmonk
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
resourceMapper.policyToTargetRefObj()so that both VpcAssociationPolicyToGateway() and TargetGroupPolicyToService could leverage itvpcAssociationPolicyEventHandler.MapToGateway()methodVpcAssociationPolicyWhat type of PR is this? Prepare for SNVA Security Group Api support #199
What does this PR do / Why do we need it: Prepare for SNVA Security Group Api support
Testing done on this change:
mapper.gokubectl apply -f examples/vpc-association-policy.yamlcould enter thegatewayReconciler.Reconcile()method if targetRef gateway existsWill this PR introduce any new dependencies?: No
Will this break upgrades or downgrades. Has updating a running cluster been tested?: No
Does this PR introduce any user-facing change?: No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.