add iam auth policy conflict handling

[mikhail-aws]

Note:
add IAM auth policy conflicts handling

Tested manually by creating multiple policies for same target ref.
Log example:

2023-10-27T13:19:32.780-0700	ERROR	controller.iam-auth-policy	controllers/iamauthpolicy_controller.go:52	conflict with other policies for same TargetRef, policy: test-iam-auth-policy, conflicted with: [test-iam-auth-policy2]

Policy Status updated:

Status:
  Conditions:
    Last Transition Time:  2023-10-27T20:13:30Z
    Message:
    Observed Generation:   1
    Reason:                Conflicted
    Status:                False
    Type:                  Accepted

[zijun726911]

What this condition used for !isDelete?

[mikhail-aws]

Thanks for pointing, logic is wrong in the code. Intention was:
If it's policy delete request and SN or Svc not found, dont throw error, just remove finalizer and we done.

[mikhail-aws]

updated condition

[mikhail-aws]

we should start doing unit tests in controllers :D

[zijun726911]

Why I think old code is correct... !isDelete && services.IsNotFoundError(err)

[mikhail-aws]

if it's policy delete and svc not found ignore, otherwise throw
(isDelete && notFound) -> ignore
!(isDelete && notFound) -> throw

[zijun726911]

for the Conflicted policy, should it just be "reconciled" with PolicyReasonConflicted status, instead of keep looping? (i.e., only the first IAMAuthPolicy takes effect and the controller just ignore other Conflicted ones )

[mikhail-aws]

with loop it should converge by itself when conflict is resolved, for example if I start controller with 2 policies, both will be in conflict state. When I remove one of them another one will succeed in ~30 sec

[coveralls]

Pull Request Test Coverage Report for Build 6672227526

• 0 of 53 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.2%) to 44.763%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
controllers/iamauthpolicy_controller.go	0	53	0.0%

Totals
Change from base Build 6660280457:	-0.2%
Covered Lines:	4133
Relevant Lines:	9233

---

💛 - Coveralls