Skip to content

Conversation

@xWink
Copy link
Member

@xWink xWink commented Nov 3, 2023

What type of PR is this?

Cleanup/feature

Which issue does this PR fix:
N/A

What does this PR do / Why do we need it:

  • Migrates controller from supporting MCS ServiceExport and ServiceImport to new ApplicationNetworking ServiceExport and ServiceImport
    • New CRD is exactly the same as before, just under a different group
    • Support for the old CRD is dropped, migration steps are outlined in release notes below
    • Dependency on MCS API is removed completely

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:

Testing done on this change:

All e2e tests pass.

Automation added to e2e:

N/A

Will this PR introduce any new dependencies?:

No, removes 1 dependency

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Yes, this is a breaking change for those using MCS ServiceExport or ServiceImport

Does this PR introduce any user-facing change?:

- Replaced support for multicluster.x-k8s.io ServiceExport and ServiceImport with support for application-networking.k8s.aws ServiceExport and ServiceImport CRDs
   - Users of the old ServiceExport and ServiceImport can migrate to the new ones with the following steps:
      1. Install the new CRDs
         - kubectl apply -f config/crds/bases/application-networking.k8s.aws_serviceexports.yaml
         - kubectl apply -f config/crds/bases/application-networking.k8s.aws_serviceimports.yaml
      2. Change the apiVersion of any ServiceExport or ServiceImport resource from multicluster.x-k8s.io/v1alpha1 to application-networking.k8s.aws/v1alpha1
         - Examples of ServiceExport and ServiceImport include:
            - examples/elasticsearch-export.yaml
            - examples/elasticsearch-import.yaml

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xWink xWink changed the title Service export and import crds Migrate ServiceExport and ServiceImport from MCS to ApplicationNetworking Nov 3, 2023
@xWink xWink changed the title Migrate ServiceExport and ServiceImport from MCS to ApplicationNetworking Migrate ServiceExport and ServiceImport from MCS to ApplicationNetworking Group Nov 3, 2023
@xWink xWink merged commit 6dcbd36 into aws:main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants