Remove deprecated gateway annotation in docs. Improve getstarted.md #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zijun726911
force-pushed
the
doc-improve-1
branch
3 times, most recently
from
48470de to
93e5f42
Compare
…ce-vpc-association: "true"` - Improve the section "Set up single-cluster/VPC service-to-service communications" in getstarted.md
zijun726911
force-pushed
the
doc-improve-1
branch
from
93e5f42 to
a3a5bf3
Compare
solmonk
reviewed
Nov 15, 2023
added 2 commits
November 15, 2023 15:02
xWink
reviewed
Nov 16, 2023
xWink
reviewed
Nov 16, 2023
xWink
reviewed
Nov 16, 2023
docs/getstarted.md
Outdated
| reason: Reconciled | ||
| status: "True" | ||
| type: Schedules | ||
| Verify that `my-hotel` gateway is created with `PROGRAMMED` equals to `True`: |
Member
There was a problem hiding this comment.
nit: Verify that my-hotel Gateway is created with a PROGRAMMED status equal to True
xWink
reviewed
Nov 16, 2023
xWink
reviewed
Nov 16, 2023
xWink
suggested changes
Nov 16, 2023
Member
xWink
left a comment
xWink
left a comment
There was a problem hiding this comment.
Only requesting small changes for clarity. Overall looks great!
Contributor
Author
|
Thank you! sent a new revision base on PR comments, please take a look if you have a time. |
xWink
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ice-vpc-association: "true"`
What type of PR is this? documentation
Changges:
application-networking.k8s.aws/lattice-vpc-association: "true"in docs and yaml examplesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.